Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit to run pre-push #355

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Update pre-commit to run pre-push #355

merged 3 commits into from
Jul 23, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jul 22, 2023 •
edited
Loading

what

  • Update make targets pr/pre-commit and pre-commit/run to only run the pre-push stage of pre-commit
  • Update Python package versions
  • Update Docker GitHub actions

why

  • Target is intended to be used pre-push, and previous target ran against all files, which both took excessively long and sometimes made unwanted changes to large numbers of untouched files.
  • PyYaml 5.4.1 no longer installs because of Cython v3, + bug and security fixes
  • Migrate away from deprecated features

references

@Nuru Nuru requested a review from a team as a code owner July 22, 2023 23:36
@Nuru Nuru added patch A minor, backward compatible change and removed modules/pre-commit labels Jul 22, 2023
@Nuru Nuru requested a review from a team as a code owner July 22, 2023 23:45
@Nuru Nuru added minor New features that do not break anything dependencies and removed patch A minor, backward compatible change labels Jul 23, 2023
@Nuru Nuru merged commit b1e1c0f into master Jul 23, 2023
@Nuru Nuru deleted the pre-commit-make branch July 23, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

@osterman osterman Awaiting requested review from osterman

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees

@Nuru Nuru

Labels
dependencies minor New features that do not break anything modules/pre-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nuru